Re: [tip:perf/core] perf/core: Check return value of the perf_event_read() IPI
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:perf/core] perf/core: Check return value of the perf_event_read() IPI
- From: Vince Weaver <vincent.weaver@xxxxxxxxx>
- Date: Mon, 29 Aug 2016 09:14:46 -0400 (EDT)
- Cc: Jiri Olsa <jolsa@xxxxxxxxxx>, Vegard Nossum <vegard.nossum@xxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Stephane Eranian <eranian@xxxxxxxxxx>, Vince Weaver <vincent.weaver@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, David Carrillo-Cisneros <davidcc@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Kan Liang <kan.liang@xxxxxxxxx>, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, Paul Turner <pjt@xxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>, linux-tip-commits@xxxxxxxxxxxxxxx
- In-reply-to: <20160829130213.GF10168@twins.programming.kicks-ass.net>
- References: <1471467307-61171-2-git-send-email-davidcc@google.com> <tip-71e7bc2bab77e64882c031c2af943c3256c1adb0@git.kernel.org> <CAOMGZ=HUNTxBOjNkP+HtD1q-yk0sOBUoMJeCu=0cKOrc8coezQ@mail.gmail.com> <20160822071737.GF4349@krava> <20160822082932.GA13171@krava> <20160822103823.GA2271@krava> <20160829100309.GS10121@twins.programming.kicks-ass.net> <20160829130213.GF10168@twins.programming.kicks-ass.net>
- User-agent: Alpine 2.20 (DEB 67 2015-01-07)
On Mon, 29 Aug 2016, Peter Zijlstra wrote:
>
> The best I can come up with is something like:
>
>
> do {
> state = READ_ONCE(event->state);
> if (state != ACTIVE)
> break;
> smp_rmb();
> cpu = READ_ONCE(event->cpu);
> smp_rmb();
> } while (READ_ONCE(event->state) != state);
>
>
> And I suppose perf_event_restart() should do the same thing... Let me
> ponder this a wee bit more.
the perf_fuzzer trips over this warning fairly regularly too, so once you
have a patch you're happy with I can give it a test.
I ordered a whole crate of null modem cables so I've got a whole bunch of
serial consoles ready and raring to go. Maybe I can find out how the
fuzzer crashes the new skylake machine, it doesn't leave anything useful
in the syslog.
Vince
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]