Re: [tip:x86/boot] x86/mm: Enable KASLR for physical mapping memory regions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [tip:x86/boot] x86/mm: Enable KASLR for physical mapping memory regions
From: Borislav Petkov <bp@xxxxxxxxx>
Date: Tue, 16 Aug 2016 23:01:08 +0200
Cc: Brian Gerst <brgerst@xxxxxxxxx>, Baoquan He <bhe@xxxxxxxxxx>, Yinghai Lu <yinghai@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Thomas Garnier <thgarnie@xxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Alexander Kuleshov <kuleshovmail@xxxxxxxxx>, Josh Poimboeuf <jpoimboe@xxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxx>, Stephen Smalley <sds@xxxxxxxxxxxxx>, "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>, Joerg Roedel <jroedel@xxxxxxx>, "Williams, Dan J" <dan.j.williams@xxxxxxxxx>, Mark Salter <msalter@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx>, Xiao Guangrong <guangrong.xiao@xxxxxxxxxxxxxxx>, "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Toshi Kani <toshi.kani@xxxxxxx>, Alexander Popov <alpopov@xxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Denys Vlasenko <dvlasenk@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Dave Young <dyoung@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Dmitry Vyukov <dvyukov@xxxxxxxxxx>, Lv Zheng <lv.zheng@xxxxxxxxx>, Martin Schwidefsky <schwidefsky@xxxxxxxxxx>, "linux-tip-commits@xxxxxxxxxxxxxxx" <linux-tip-commits@xxxxxxxxxxxxxxx>
In-reply-to: <CAGXu5jLC4XzQyaw4C7ohPimmQu-eddixN_TW9HCnGY4ZU_AyRg@mail.gmail.com>
References: <1466556426-32664-7-git-send-email-keescook@chromium.org> <tip-021182e52fe01c1f7b126f97fd6ba048dc4234fd@git.kernel.org> <CAMzpN2h-CV2e1F_8u5GYkwaFkzoERfi9a83DEO7OeKEJB0RYTg@mail.gmail.com> <20160814232657.GA10704@x1.redhat.com> <CAMzpN2ixxOEonfgDdFRkB8P9Zb6eiFJF4Vx_HRMgWhm-7wK1hg@mail.gmail.com> <20160816134205.GB11106@nazgul.tnic> <20160816134928.GC11106@nazgul.tnic> <20160816155412.GB15004@nazgul.tnic> <20160816175008.GA10538@nazgul.tnic> <CAGXu5jLC4XzQyaw4C7ohPimmQu-eddixN_TW9HCnGY4ZU_AyRg@mail.gmail.com>
User-agent: Mutt/1.6.0 (2016-04-01)

On Tue, Aug 16, 2016 at 12:49:52PM -0700, Kees Cook wrote:
> Am I misreading this?

No you're not.

> Shouldn't it be:
> 
>        cont = container;
> #ifdef CONFIG_RANDOMIZE_MEMORY
>        cont += PAGE_OFFSET - __PAGE_OFFSET_BASE;
> #endif
> 
> (otherwise cont is undefined in the RANDOMIZE_MEMORY=n case?)

Thanks for catching this Kees, I'll send a new version in the morning.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Follow-Ups:
- Re: [tip:x86/boot] x86/mm: Enable KASLR for physical mapping memory regions
  - From: Brian Gerst

References:
- [tip:x86/boot] x86/mm: Enable KASLR for physical mapping memory regions
  - From: tip-bot for Thomas Garnier
- Re: [tip:x86/boot] x86/mm: Enable KASLR for physical mapping memory regions
  - From: Brian Gerst
- Re: [tip:x86/boot] x86/mm: Enable KASLR for physical mapping memory regions
  - From: Baoquan He
- Re: [tip:x86/boot] x86/mm: Enable KASLR for physical mapping memory regions
  - From: Brian Gerst
- Re: [tip:x86/boot] x86/mm: Enable KASLR for physical mapping memory regions
  - From: Borislav Petkov
- Re: [tip:x86/boot] x86/mm: Enable KASLR for physical mapping memory regions
  - From: Borislav Petkov
- Re: [tip:x86/boot] x86/mm: Enable KASLR for physical mapping memory regions
  - From: Borislav Petkov
- Re: [tip:x86/boot] x86/mm: Enable KASLR for physical mapping memory regions
  - From: Borislav Petkov
- Re: [tip:x86/boot] x86/mm: Enable KASLR for physical mapping memory regions
  - From: Kees Cook

Prev by Date: Re: [tip:x86/boot] x86/mm: Enable KASLR for physical mapping memory regions
Next by Date: Re: [tip:x86/boot] x86/mm: Enable KASLR for physical mapping memory regions
Previous by thread: Re: [tip:x86/boot] x86/mm: Enable KASLR for physical mapping memory regions
Next by thread: Re: [tip:x86/boot] x86/mm: Enable KASLR for physical mapping memory regions
Index(es):
- Date
- Thread

[Index of Archives] [Linux Stable Commits] [Linux Stable Kernel] [Linux Kernel] [Linux USB Devel] [Linux Video &Media] [Linux Audio Users] [Yosemite News] [Linux SCSI]