Commit-ID: 8bc55f805697ec2a69c6a576fac8ee36ea9772bb Gitweb: http://git.kernel.org/tip/8bc55f805697ec2a69c6a576fac8ee36ea9772bb Author: Luis R. Rodriguez <mcgrof@xxxxxxxxxx> AuthorDate: Wed, 13 Apr 2016 17:04:38 -0700 Committer: Ingo Molnar <mingo@xxxxxxxxxx> CommitDate: Fri, 22 Apr 2016 10:29:03 +0200 x86/apm32: Remove paravirt_enabled() use There is already a check for apm_info.bios == 0, the apm_info.bios is set from the boot_params.apm_bios_info. Both Xen and lguest, which are also the only ones that set paravirt_enabled to true, never set the apm_bios.info. The Xen folks are sure force disable to 0 is not needed because apm_info lives in .bss, we recently forced disabled this on lguest, and on the Xen side just to be sure Boris zeroed out the .bss for PV guests through commit 04b6b4a56884327c1648 ("xen/x86: Zero out .bss for PV guests"). With this care taken into consideration the paravirt_enabled() check is simply not needed anymore. Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxx> Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx> Cc: Borislav Petkov <bp@xxxxxxxxx> Cc: Brian Gerst <brgerst@xxxxxxxxx> Cc: Denys Vlasenko <dvlasenk@xxxxxxxxxx> Cc: H. Peter Anvin <hpa@xxxxxxxxx> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> Cc: andrew.cooper3@xxxxxxxxxx Cc: andriy.shevchenko@xxxxxxxxxxxxxxx Cc: bigeasy@xxxxxxxxxxxxx Cc: boris.ostrovsky@xxxxxxxxxx Cc: david.vrabel@xxxxxxxxxx Cc: ffainelli@xxxxxxxxxx Cc: george.dunlap@xxxxxxxxxx Cc: glin@xxxxxxxx Cc: jgross@xxxxxxxx Cc: jlee@xxxxxxxx Cc: josh@xxxxxxxxxxxxxxxx Cc: julien.grall@xxxxxxxxxx Cc: konrad.wilk@xxxxxxxxxx Cc: kozerkov@xxxxxxxxxxxxx Cc: lenb@xxxxxxxxxx Cc: lguest@xxxxxxxxxxxxxxxx Cc: linux-acpi@xxxxxxxxxxxxxxx Cc: lv.zheng@xxxxxxxxx Cc: matt@xxxxxxxxxxxxxxxxxxx Cc: mbizon@xxxxxxxxxx Cc: rjw@xxxxxxxxxxxxx Cc: robert.moore@xxxxxxxxx Cc: rusty@xxxxxxxxxxxxxxx Cc: tiwai@xxxxxxx Cc: toshi.kani@xxxxxx Cc: xen-devel@xxxxxxxxxxxxxxxxxxx Link: http://lkml.kernel.org/r/1460592286-300-9-git-send-email-mcgrof@xxxxxxxxxx Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx> --- arch/x86/kernel/apm_32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/apm_32.c b/arch/x86/kernel/apm_32.c index 9307f18..c7364bd 100644 --- a/arch/x86/kernel/apm_32.c +++ b/arch/x86/kernel/apm_32.c @@ -2267,7 +2267,7 @@ static int __init apm_init(void) dmi_check_system(apm_dmi_table); - if (apm_info.bios.version == 0 || paravirt_enabled() || machine_is_olpc()) { + if (apm_info.bios.version == 0 || machine_is_olpc()) { printk(KERN_INFO "apm: BIOS not found.\n"); return -ENODEV; } -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |