Re: [tip:smp/hotplug] rcu: Make CPU_DYING_IDLE an explicit call
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:smp/hotplug] rcu: Make CPU_DYING_IDLE an explicit call
- From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
- Date: Thu, 3 Mar 2016 08:31:35 +0100 (CET)
- Cc: rafael.j.wysocki@xxxxxxxxx, peterz@xxxxxxxxxxxxx, riel@xxxxxxxxxx, arjan@xxxxxxxxxxxxxxx, rusty@xxxxxxxxxxxxxxx, tj@xxxxxxxxxx, srivatsa@xxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, bigeasy@xxxxxxxxxxxxx, pjt@xxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, hpa@xxxxxxxxx, oleg@xxxxxxxxxx, mingo@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, rostedt@xxxxxxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx
- In-reply-to: <20160302201127.GA23440@linux.vnet.ibm.com>
- User-agent: Alpine 2.11 (DEB 23 2013-08-11)
On Wed, 2 Mar 2016, Paul E. McKenney wrote:
> > --- a/kernel/cpu.c
> > +++ b/kernel/cpu.c
> > @@ -762,6 +762,7 @@ void cpuhp_report_idle_dead(void)
> > BUG_ON(st->state != CPUHP_AP_OFFLINE);
> > st->state = CPUHP_AP_IDLE_DEAD;
> > complete(&st->done);
>
> Not to be repetitive or anything, but if we delay here, it can break
> RCU on a number of architectures. Either the CPU can be killed holding
> one of RCU's locks or RCU can wrongly see the CPU as still being alive.
> Either can prevent future RCU grace periods from ever completing, thus
> OOMing the system.
Thanks for the reminder. I wanted to fix that, but then forgot again. Fix is
on the way.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]