Re: [tip:x86/mm] x86/mm/numa: Clean up numa_clear_kernel_node_hotplug ()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:x86/mm] x86/mm/numa: Clean up numa_clear_kernel_node_hotplug ()
- From: Ingo Molnar <mingo@xxxxxxxxxx>
- Date: Mon, 8 Feb 2016 12:18:08 +0100
- Cc: linux-tip-commits@xxxxxxxxxxxxxxx, zhangyanfei@xxxxxxxxxxxxxx, wency@xxxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, imtangchen@xxxxxxxxx, spender@xxxxxxxxxxxxxx, hpa@xxxxxxxxx, tangchen@xxxxxxxxxxxxxx, y14sg1@xxxxxxxxxxx, isimatu.yasuaki@xxxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, izumi.taku@xxxxxxxxxxxxxx, laijs@xxxxxxxxxxxxxx
- In-reply-to: <56B86F95.12384.11AF6415@pageexec.freemail.hu>
- User-agent: Mutt/1.5.23 (2014-03-12)
* PaX Team <pageexec@xxxxxxxxxxx> wrote:
> On 8 Feb 2016 at 1:42, tip-bot for Ingo Molnar wrote:
>
> > for (i = 0; i < numa_meminfo.nr_blks; i++) {
> > - struct numa_memblk *mb = &numa_meminfo.blk[i];
> > + struct numa_memblk *mb = numa_meminfo.blk + i;
> >
> > - memblock_set_node(mb->start, mb->end - mb->start,
> > - &memblock.reserved, mb->nid);
> > + memblock_set_node(mb->start, mb->end-mb->start, &memblock.reserved, mb->nid);
>
> if you're not keeping to the 80-char length (no complaints from me on that), could
> you also use some whitespace around the '-' operator for more readability?
Yeah, like I did it later in the function:
+ memblock_clear_hotplug(mb->start, mb->end - mb->start);
Fixed.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]