Hi, Tested these changes on top of my uapi headers fix branch and they compile without problems in userspace and thus fix the original issue. Also abi-compliance-checker reports that these changes don't break anything in i386 ABI (details at [2]): "Test Info Library Name kernel Version #1 headers_test_v04 Version #2 headers_test_v04+test_ingo_x86_cleanup CPU Type x86 GCC Version 5.2.1 Subject Binary Compatibility Test Results Total Header Files 767 Total Shared Libraries 0 (not analyzed) Total Symbols / Types 62 / 67 Verdict Compatible" or API: "Test Info Library Name kernel Version #1 headers_test_v04 Version #2 headers_test_v04+test_ingo_x86_cleanup CPU Type x86 GCC Version 5.2.1 Subject Source Compatibility Test Results Total Header Files 767 Total Shared Libraries 0 (not analyzed) Total Symbols / Types 96 / 101 Verdict Compatible" While abi-compliance-checker is still quite broken with kernel header files[3] addition of new constants was correctly detected: "Other Changes in Constants (3) sigcontext.h [−] _fpstate Change Effect 1 The constant _fpstate with value _fpstate_32 has been added. No effect. [−] _fpstate_ia32 Change Effect 1 The constant _fpstate_ia32 with value _fpstate_32 has been added. No effect. [−] sigcontext_ia32 Change Effect 1 The constant sigcontext_ia32 with value sigcontext_32 has been added. No effect." So for 32 bit userspace side Tested-by: Mikko Rapeli <mikko.rapeli@xxxxxx> -Mikko [1] http://lvc.github.io/abi-compliance-checker/ [2] API/ABI check results https://mcfrisk.kapsi.fi/temp/headers_test_v04_to_headers_test_v04+test_ingo_x86_cleanup/ [3] abi checker still has some issues with kernel headers: https://mcfrisk.kapsi.fi/temp/headers_test_v04+test_ingo_x86_cleanup/log.txt -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |