Re: [tip:x86/asm] x86/vm86: Clean up vm86.h includes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 31, 2015 at 10:04 AM, tip-bot for Brian Gerst
<tipbot@xxxxxxxxx> wrote:
> Commit-ID:  ba3e127ec105e790eeec4034d9769e018e4a1b54
> Gitweb:     http://git.kernel.org/tip/ba3e127ec105e790eeec4034d9769e018e4a1b54
> Author:     Brian Gerst <brgerst@xxxxxxxxx>
> AuthorDate: Wed, 29 Jul 2015 01:41:21 -0400
> Committer:  Ingo Molnar <mingo@xxxxxxxxxx>
> CommitDate: Fri, 31 Jul 2015 13:31:10 +0200
>
> x86/vm86: Clean up vm86.h includes
>
> vm86.h was being implicitly included in alot of places via
> processor.h, which in turn got it from math_emu.h.  Break that
> chain and explicitly include vm86.h in all files that need it.
> Also remove unused vm86 field from math_emu_info.
>
> Signed-off-by: Brian Gerst <brgerst@xxxxxxxxx>
> Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx>
> Cc: Denys Vlasenko <dvlasenk@xxxxxxxxxx>
> Cc: H. Peter Anvin <hpa@xxxxxxxxx>
> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Link: http://lkml.kernel.org/r/1438148483-11932-7-git-send-email-brgerst@xxxxxxxxx
> [ Fixed build failure. ]
> Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>


> diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> index f35ed53..d4cda5e 100644
> --- a/drivers/scsi/dpt_i2o.c
> +++ b/drivers/scsi/dpt_i2o.c
> @@ -1924,6 +1924,9 @@ static void adpt_alpha_info(sysInfo_S* si)
>  #endif
>
>  #if defined __i386__
> +
> +#include <uapi/asm/vm86.h>
> +
>  static void adpt_i386_info(sysInfo_S* si)
>  {
>         // This is all the info we need for now

It would have been better to just remove the the CPU_* defines from
this driver.  boot_cpu_data.x86 is simply the family ID from CPUID,
and nowhere else uses defines like this.

--
Brian Gerst
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Stable Commits]     [Linux Stable Kernel]     [Linux Kernel]     [Linux USB Devel]     [Linux Video &Media]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux