I'm sorry Ingo, but this is definitely a step in the wrong direction. The only connection between the system call numbers and three entry code is the system call table, which is cleanly abstracted, so this just adds confusion, it doesn't improve things.
I like the entry code separation, but for it to make sense please let's leave it to be the entry code...
On June 4, 2015 7:13:53 AM PDT, tip-bot for Ingo Molnar <tipbot@xxxxxxxxx> wrote:
>Commit-ID: 1f57d5d85ba7f1f467173ff33f51d01a91f9aaf1
>Gitweb:
>http://git.kernel.org/tip/1f57d5d85ba7f1f467173ff33f51d01a91f9aaf1
>Author: Ingo Molnar <mingo@xxxxxxxxxx>
>AuthorDate: Wed, 3 Jun 2015 18:36:41 +0200
>Committer: Ingo Molnar <mingo@xxxxxxxxxx>
>CommitDate: Thu, 4 Jun 2015 07:37:37 +0200
>
>x86/asm/entry: Move the arch/x86/syscalls/ definitions to
>arch/x86/entry/syscalls/
>
>The build time generated syscall definitions are entry code related,
>move
>them into the arch/x86/entry/ directory.
>
>Cc: Borislav Petkov <bp@xxxxxxxxx>
>Cc: H. Peter Anvin <hpa@xxxxxxxxx>
>Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
>Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
>Cc: Denys Vlasenko <dvlasenk@xxxxxxxxxx>
>Cc: Brian Gerst <brgerst@xxxxxxxxx>
>Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>Cc: linux-kernel@xxxxxxxxxxxxxxx
>Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
>---
> arch/x86/Makefile | 2 +-
> arch/x86/{ => entry}/syscalls/Makefile | 4 ++--
> arch/x86/{ => entry}/syscalls/syscall_32.tbl | 0
> arch/x86/{ => entry}/syscalls/syscall_64.tbl | 0
> arch/x86/{ => entry}/syscalls/syscallhdr.sh | 0
> arch/x86/{ => entry}/syscalls/syscalltbl.sh | 0
> scripts/checksyscalls.sh | 2 +-
> 7 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/arch/x86/Makefile b/arch/x86/Makefile
>index 90b1c3b..118e6de 100644
>--- a/arch/x86/Makefile
>+++ b/arch/x86/Makefile
>@@ -181,7 +181,7 @@ archscripts: scripts_basic
> # Syscall table generation
>
> archheaders:
>- $(Q)$(MAKE) $(build)=arch/x86/syscalls all
>+ $(Q)$(MAKE) $(build)=arch/x86/entry/syscalls all
>
> archprepare:
> ifeq ($(CONFIG_KEXEC_FILE),y)
>diff --git a/arch/x86/syscalls/Makefile
>b/arch/x86/entry/syscalls/Makefile
>similarity index 95%
>rename from arch/x86/syscalls/Makefile
>rename to arch/x86/entry/syscalls/Makefile
>index a55abb9..57aa59f 100644
>--- a/arch/x86/syscalls/Makefile
>+++ b/arch/x86/entry/syscalls/Makefile
>@@ -1,5 +1,5 @@
>-out := $(obj)/../include/generated/asm
>-uapi := $(obj)/../include/generated/uapi/asm
>+out := $(obj)/../../include/generated/asm
>+uapi := $(obj)/../../include/generated/uapi/asm
>
> # Create output directory if not already present
> _dummy := $(shell [ -d '$(out)' ] || mkdir -p '$(out)') \
>diff --git a/arch/x86/syscalls/syscall_32.tbl
>b/arch/x86/entry/syscalls/syscall_32.tbl
>similarity index 100%
>rename from arch/x86/syscalls/syscall_32.tbl
>rename to arch/x86/entry/syscalls/syscall_32.tbl
>diff --git a/arch/x86/syscalls/syscall_64.tbl
>b/arch/x86/entry/syscalls/syscall_64.tbl
>similarity index 100%
>rename from arch/x86/syscalls/syscall_64.tbl
>rename to arch/x86/entry/syscalls/syscall_64.tbl
>diff --git a/arch/x86/syscalls/syscallhdr.sh
>b/arch/x86/entry/syscalls/syscallhdr.sh
>similarity index 100%
>rename from arch/x86/syscalls/syscallhdr.sh
>rename to arch/x86/entry/syscalls/syscallhdr.sh
>diff --git a/arch/x86/syscalls/syscalltbl.sh
>b/arch/x86/entry/syscalls/syscalltbl.sh
>similarity index 100%
>rename from arch/x86/syscalls/syscalltbl.sh
>rename to arch/x86/entry/syscalls/syscalltbl.sh
>diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh
>index 5b3add3..2c9082b 100755
>--- a/scripts/checksyscalls.sh
>+++ b/scripts/checksyscalls.sh
>@@ -212,5 +212,5 @@ EOF
> )
> }
>
>-(ignore_list && syscall_list $(dirname
>$0)/../arch/x86/syscalls/syscall_32.tbl) | \
>+(ignore_list && syscall_list $(dirname
>$0)/../arch/x86/entry/syscalls/syscall_32.tbl) | \
> $* -E -x c - > /dev/null
--
Sent from my mobile phone. Please pardon brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|