Commit-ID: be73dc63ac6037285d980d95e5223a23feb4462e Gitweb: http://git.kernel.org/tip/be73dc63ac6037285d980d95e5223a23feb4462e Author: Andre Przywara <andre.przywara@xxxxxxx> AuthorDate: Fri, 9 Jan 2015 15:58:19 +0000 Committer: Will Deacon <will.deacon@xxxxxxx> CommitDate: Fri, 16 Jan 2015 15:16:19 +0000 kvmtool: remove 8250 IRQ line reset on device_init Currently we reset the KVM interrupt line on initializing the 8250 serial device emulation. For ARM this creates a problem where we use the in-kernel IRQ chip before having fully initialized it. But with the new kernel interface we cannot finish the GIC initialization before we know the number of used IRQs, so we have to wait until all devices have been created and initialized. Since the in-kernel GIC emulation resets the IRQ line anyway and also QEMU gets away without resetting it, the easiest solution is to drop the IRQ line reset. Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx> Signed-off-by: Will Deacon <will.deacon@xxxxxxx> --- tools/kvm/hw/serial.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/kvm/hw/serial.c b/tools/kvm/hw/serial.c index 270e6182..2f19ba8 100644 --- a/tools/kvm/hw/serial.c +++ b/tools/kvm/hw/serial.c @@ -406,7 +406,6 @@ static int serial8250__device_init(struct kvm *kvm, struct serial8250_device *de ioport__map_irq(&dev->irq); r = ioport__register(kvm, dev->iobase, &serial8250_ops, 8, dev); - kvm__irq_line(kvm, dev->irq, 0); return r; } -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |