Re: [tip:x86/asm] sched/x86_64: Don't save flags on context switch
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:x86/asm] sched/x86_64: Don't save flags on context switch
- From: Oleg Nesterov <oleg@xxxxxxxxxx>
- Date: Mon, 3 Nov 2014 23:57:21 +0100
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Sebastian Lackner <sebastian@xxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Chuck Ebbert <cebbert.lkml@xxxxxxxxx>, Anish Bhatt <anish@xxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, "linux-tip-commits@xxxxxxxxxxxxxxx" <linux-tip-commits@xxxxxxxxxxxxxxx>
- In-reply-to: <CALCETrUMLaz_McO=f-v6JmPY7pJSU4M4g1+p1un1UiVcNf+4XQ@mail.gmail.com>
- User-agent: Mutt/1.5.18 (2008-05-17)
Argh, sorry for confusion...
On 11/03, Andy Lutomirski wrote:
>
> On Mon, Nov 3, 2014 at 1:58 PM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> > On 11/03, Oleg Nesterov wrote:
> >>
> > Btw, why retint_kernel() checks "interrupts on" ? It seems to me that
> > that "interrupts off" is not possible, no? And this will be more clear
> > when we remove the "exit_intr" label.
>
> We might get there from #MC or from any of a number of synchronous
> errors (#GP from xyz_safe, #PF from some atomic uaccess thing or a
> vmap fault, etc), and all of those have interrupts off.
Yes, yes, exactly.
I actually tried to say that irqs should be always disabled (afaics!).
IOW "interrupts on" should not be possible, not "interrupts off".
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]
