Re: [tip:perf/urgent] perf/x86: Fix compile warnings for intel_uncore
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:perf/urgent] perf/x86: Fix compile warnings for intel_uncore
- From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
- Date: Tue, 28 Oct 2014 13:42:28 +0100
- Cc: akpm@xxxxxxxxxxxxxxxxxxxx, mingo@xxxxxxxxxx, bp@xxxxxxx, eranian@xxxxxxxxxx, zheng.z.yan@xxxxxxxxx, hpa@xxxxxxxxx, tglx@xxxxxxxxxxxxx, josh@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx
- In-reply-to: <20141028111921.GB3274@tassilo.jf.intel.com>
- User-agent: Mutt/1.5.21 (2012-12-30)
On Tue, Oct 28, 2014 at 04:19:21AM -0700, Andi Kleen wrote:
> > +config PERF_EVENTS_INTEL_UNCORE
> > + def_bool y
>
> Why not give it a user name? It should be user configurable.
To avoid just that, another more or less pointless config option.
> > + depends on PERF_EVENTS && SUP_SUP_INTEL && PCI
>
> SUP_SUP_INTEL looks wrong. Should be CPU_SUP_INTEL
>
> I suspect you disabled it completely.
Indeed, typo there.
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]
