Commit-ID: d4922a95a70f0c8c5e45e22af629a5b5f370b867 Gitweb: http://git.kernel.org/tip/d4922a95a70f0c8c5e45e22af629a5b5f370b867 Author: Nishanth Menon <nm@xxxxxx> AuthorDate: Thu, 26 Jun 2014 12:40:24 +0530 Committer: Jason Cooper <jason@xxxxxxxxxxxxxx> CommitDate: Mon, 30 Jun 2014 19:11:21 +0000 irqchip: crossbar: Remove IS_ERR_VALUE check IS_ERR_VALUE makes sense only *if* there could be valid values in negative error range. But in the cases that we do use it, there is no such case. Just remove the same. Signed-off-by: Nishanth Menon <nm@xxxxxx> Signed-off-by: Sricharan R <r.sricharan@xxxxxx> Acked-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx> Link: https://lkml.kernel.org/r/1403766634-18543-7-git-send-email-r.sricharan@xxxxxx Signed-off-by: Jason Cooper <jason@xxxxxxxxxxxxxx> --- drivers/irqchip/irq-crossbar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index a39cb31..88fbe0f 100644 --- a/drivers/irqchip/irq-crossbar.c +++ b/drivers/irqchip/irq-crossbar.c @@ -102,15 +102,15 @@ static int crossbar_domain_xlate(struct irq_domain *d, unsigned long *out_hwirq, unsigned int *out_type) { - unsigned long ret; + int ret; ret = get_prev_map_irq(intspec[1]); - if (!IS_ERR_VALUE(ret)) + if (ret >= 0) goto found; ret = allocate_free_irq(intspec[1]); - if (IS_ERR_VALUE(ret)) + if (ret < 0) return ret; found: -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html