Commit-ID: 25dc49e3321a3b3f17b3f78297432073bb14ec0b
Gitweb: http://git.kernel.org/tip/25dc49e3321a3b3f17b3f78297432073bb14ec0b
Author: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
AuthorDate: Thu, 19 Jun 2014 21:34:42 +0000
Committer: Jason Cooper <jason@xxxxxxxxxxxxxx>
CommitDate: Tue, 24 Jun 2014 12:38:17 +0000
irqchip: spear_shirq: Simplify chained handler
I don't know if there are less efficient ways to code that. Get rid of
the loop mess and use efficient code.
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Link: https://lkml.kernel.org/r/20140619212713.662897061@xxxxxxxxxxxxx
Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
Signed-off-by: Jason Cooper <jason@xxxxxxxxxxxxxx>
---
drivers/irqchip/spear-shirq.c | 19 ++++++++-----------
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/irqchip/spear-shirq.c b/drivers/irqchip/spear-shirq.c
index 2a33129..8521a72 100644
--- a/drivers/irqchip/spear-shirq.c
+++ b/drivers/irqchip/spear-shirq.c
@@ -224,23 +224,20 @@ static void shirq_handler(unsigned irq, struct irq_desc *desc)
struct spear_shirq *shirq = irq_get_handler_data(irq);
struct irq_data *idata = irq_desc_get_irq_data(desc);
struct irq_chip *chip = irq_data_get_irq_chip(idata);
- u32 i, j, val, mask;
+ u32 pend;
chip->irq_ack(idata);
- mask = shirq->mask;
- while ((val = readl(shirq->base + shirq->regs.status_reg) &
- mask)) {
+ pend = readl(shirq->base + shirq->regs.status_reg) & shirq->mask;
+ pend >>= shirq->offset;
- val >>= shirq->offset;
- for (i = 0, j = 1; i < shirq->nr_irqs; i++, j <<= 1) {
+ while (pend) {
+ int irq = __ffs(pend);
- if (!(j & val))
- continue;
-
- generic_handle_irq(shirq->virq_base + i);
- }
+ pend &= ~(0x1 << irq);
+ generic_handle_irq(shirq->virq_base + irq);
}
+
chip->irq_unmask(idata);
}
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|