Commit-ID: c0f1527b7e004f9a91e488f05c251213d16ad7ac Gitweb: http://git.kernel.org/tip/c0f1527b7e004f9a91e488f05c251213d16ad7ac Author: Namhyung Kim <namhyung@xxxxxxxxxx> AuthorDate: Wed, 16 Apr 2014 11:16:33 +0900 Committer: Jiri Olsa <jolsa@xxxxxxxxxx> CommitDate: Wed, 21 May 2014 11:45:36 +0200 perf report/tui: Fix a bug when --fields/sort is given The hists__filter_entries() function is called when down arrow key is pressed for navigating through the entries in TUI. It has a check for filtering out entries that have very small overhead (under min_pcnt). However it just assumed the entries are sorted by the overhead so when it saw such a small overheaded entry, it just stopped navigating as an optimization. But it's not true anymore due to new --fields and --sort optoin behavior and this case users cannot go down to a next entry if ther's an entry with small overhead in-between. Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx> Link: http://lkml.kernel.org/r/1400480762-22852-14-git-send-email-namhyung@xxxxxxxxxx Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx> --- tools/perf/ui/browsers/hists.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index 92d128f..169224c 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c @@ -812,10 +812,7 @@ static struct rb_node *hists__filter_entries(struct rb_node *nd, if (total) percent = h->stat.period * 100.0 / total; - if (percent < min_pcnt) - return NULL; - - if (!h->filtered) + if (!h->filtered && percent >= min_pcnt) return nd; nd = rb_next(nd); -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|