Re: [tip:sched/core] sched: Rework sched_domain topology definition
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:sched/core] sched: Rework sched_domain topology definition
- From: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
- Date: Sun, 18 May 2014 10:04:01 +0200
- Cc: Ingo Molnar <mingo@xxxxxxxxxx>, Hanjun Guo <hanjun.guo@xxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, "schwidefsky@xxxxxxxxxx" <schwidefsky@xxxxxxxxxx>, Chris Metcalf <cmetcalf@xxxxxxxxxx>, Christoph Lameter <cl@xxxxxxxxx>, Jason Low <jason.low2@xxxxxx>, "tony.luck@xxxxxxxxx" <tony.luck@xxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, "heiko.carstens@xxxxxxxxxx" <heiko.carstens@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Dietmar Eggemann <dietmar.eggemann@xxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, bhelgaas@xxxxxxxxxx, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Preeti U Murthy <preeti@xxxxxxxxxxxxxxxxxx>, "fenghua.yu@xxxxxxxxx" <fenghua.yu@xxxxxxxxx>, linux-tip-commits@xxxxxxxxxxxxxxx, metag <linux-metag@xxxxxxxxxxxxxxx>
- In-reply-to: <CAAG0J9915TAT-9JUjz5cMQ_ze7jayhNpKpjZdCZG9JzW1ocBsA@mail.gmail.com>
On 16 May 2014 11:57, James Hogan <james.hogan@xxxxxxxxxx> wrote:
> Hi Vincent,
>
[snip]
>
>
>> diff --git a/include/linux/sched.h b/include/linux/sched.h
>> index 2a4298f..656b035 100644
>> --- a/include/linux/sched.h
>> +++ b/include/linux/sched.h
>> @@ -985,6 +1006,38 @@ void free_sched_domains(cpumask_var_t doms[], unsigned int ndoms);
>>
>> bool cpus_share_cache(int this_cpu, int that_cpu);
>>
>> +typedef const struct cpumask *(*sched_domain_mask_f)(int cpu);
>> +typedef const int (*sched_domain_flags_f)(void);
>
> I just noticed, since May 9th, linux-next (ARCH=metag, gcc 4.2.4, with
> meta2_smp_defconfig) is showing loads of warnings due to the above
> line:
>
> include/linux/sched.h +1010 : warning: type qualifiers ignored on
> function return type
>
> Looks to me that the const serves no purpose in this context and could
> be removed.
Hi James,
Ok, i'm going to have a look a it. I haven't seen such warning during
my test but my configuration was different (ARCH=ARM gcc 4.7.1)
Thanks,
Vincent
>
> Cheers
> James
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]