Commit-ID: aa5125a45568f8f666f6d2f224fe8ab261b1069e Gitweb: http://git.kernel.org/tip/aa5125a45568f8f666f6d2f224fe8ab261b1069e Author: Thomas Gleixner <tglx@xxxxxxxxxxxxx> AuthorDate: Wed, 7 May 2014 15:44:10 +0000 Committer: Thomas Gleixner <tglx@xxxxxxxxxxxxx> CommitDate: Fri, 16 May 2014 14:05:19 +0200 iommu: smar: Fix return value check of create_irq() ia64 returns a negative error code when allocation fails andx86 returns 0. Make it handle both. Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> Reviewed-by: Grant Likely <grant.likely@xxxxxxxxxx> Cc: Tony Luck <tony.luck@xxxxxxxxx> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx> Cc: Fenghua Yu <fenghua.yu@xxxxxxxxx> Cc: x86@xxxxxxxxxx Acked-by: Joerg Roedel <joro@xxxxxxxxxx> Cc: linux-ia64@xxxxxxxxxxxxxxx Cc: iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx Link: http://lkml.kernel.org/r/20140507154336.178850165@xxxxxxxxxxxxx Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> --- drivers/iommu/dmar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c index 39f8b71..3ce1f62 100644 --- a/drivers/iommu/dmar.c +++ b/drivers/iommu/dmar.c @@ -1551,7 +1551,7 @@ int dmar_set_interrupt(struct intel_iommu *iommu) return 0; irq = create_irq(); - if (!irq) { + if (irq <= 0) { pr_err("IOMMU: no free vectors\n"); return -EINVAL; } -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |