Re: [PATCH] x86, MCE: Clean get_cpu_xxx with this_cpu_xxx

"Chen, Gong" <gong.chen@xxxxxxxxxxxxxxx> · Tue, 15 Apr 2014 21:34:59 -0400

On Tue, Apr 15, 2014 at 11:03:48AM +0200, Ingo Molnar wrote:
> Date: Tue, 15 Apr 2014 11:03:48 +0200
> From: Ingo Molnar <mingo@xxxxxxxxxx>
> To: "Chen, Gong" <gong.chen@xxxxxxxxxxxxxxx>
> Cc: hpa@xxxxxxxxx, tony.luck@xxxxxxxxx, tglx@xxxxxxxxxxxxx,
>  linux-kernel@xxxxxxxxxxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] x86, MCE: Clean get_cpu_xxx with this_cpu_xxx
> User-Agent: Mutt/1.5.21 (2010-09-15)
> 
> 
> * Chen, Gong <gong.chen@xxxxxxxxxxxxxxx> wrote:
> 
> > This is a cleanup patch suggested by Peter. Use new
> > this_cpu_xxx to improve operation speed. Meanwhile,
> > it fixes an issue introduced in commit 27f6c573e0. I
> > forget to execute put_cpu_var operation after get_cpu_var.
> 
> What 'issue'? Is it a bug? If yes, what are the symptoms to the user?
I forget put_cpu_var after get_cpu_var.

> 
> Also, fixes must be separate from cleanups.
OK, I will.