Commit-ID: cbceb6904f9d99d068711903fc769b84cf036689 Gitweb: http://git.kernel.org/tip/cbceb6904f9d99d068711903fc769b84cf036689 Author: Neil Horman <nhorman@xxxxxxxxxxxxx> AuthorDate: Wed, 12 Mar 2014 14:44:33 -0400 Committer: Thomas Gleixner <tglx@xxxxxxxxxxxxx> CommitDate: Wed, 19 Mar 2014 13:57:57 +0100 x86: Adjust irq remapping quirk for older revisions of 5500/5520 chipsets Commit 03bbcb2e7e2 (iommu/vt-d: add quirk for broken interrupt remapping on 55XX chipsets) properly disables irq remapping on the 5500/5520 chipsets that don't correctly perform that feature. However, when I wrote it, I followed the errata sheet linked in that commit too closely, and explicitly tied the activation of the quirk to revision 0x13 of the chip, under the assumption that earlier revisions were not in the field. Recently a system was reported to be suffering from this remap bug and the quirk hadn't triggered, because the revision id register read at a lower value that 0x13, so the quirk test failed improperly. Given this, it seems only prudent to adjust this quirk so that any revision less than 0x13 has the quirk asserted. Signed-off-by: Neil Horman <nhorman@xxxxxxxxxxxxx> Cc: Ingo Molnar <mingo@xxxxxxxxxx> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx> Cc: x86@xxxxxxxxxx Cc: stable@xxxxxxxxxxxxxxx Link: http://lkml.kernel.org/r/1394649873-14913-1-git-send-email-nhorman@xxxxxxxxxxxxx Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> --- arch/x86/kernel/early-quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c index bc4a088..2237b36 100644 --- a/arch/x86/kernel/early-quirks.c +++ b/arch/x86/kernel/early-quirks.c @@ -208,7 +208,7 @@ static void __init intel_remapping_check(int num, int slot, int func) * and should be flagged as broken. Additionally revisions 0x12 * and 0x22 of device id 0x3405 has this problem. */ - if (revision == 0x13) + if (revision < 0x13) set_irq_remapping_broken(); else if ((device == 0x3405) && ((revision == 0x12) || -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|