On Wed, 5 Mar 2014 13:25:35 +0100 Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote: > On Wed, Mar 05, 2014 at 07:20:22AM -0500, Steven Rostedt wrote: > > On Wed, 5 Mar 2014 12:14:15 +0100 > > Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote: > > > > Please no! I used tracing of the do_page_fault function all the time. > > It is very useful. > > Why do you trace do_page_fault and not the __do_page_fault() function? > do_page_fault() is a minimal wrapper which doesn't actually do all that > much? Then we better make sure that __do_page_fault() is never inlined. Otherwise, it wont be available to trace. I'm fine with adding "notrace" to do_page_fault() and to trace_do_page_fault() as long as we also include a "noinline" to __do_page_fault(). Would need a comment stating why that noinline is there though. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|