[[PATCH] um, x86: Fix vDSO build] On 12/01/2014 (Sun 15:52) Richard Weinberger wrote: > Commit "x86: Delete non-required instances of include <linux/init.h>" > broke the UML build. > > arch/x86/um/vdso/vdso.S: Assembler messages: > arch/x86/um/vdso/vdso.S:2: Error: no such instruction: `__initdata' > arch/x86/um/vdso/vdso.S:9: Error: no such instruction: `__finit' > > UML's vDSO needs linux/init.h. > > Signed-off-by: Richard Weinberger <richard@xxxxxx> Thanks Richard & Ingo. I did these cleanups last fall but never got around to submitting them until now; I think the false positives for removal crept in when I manually started the process, before realizing the scale of it needed automatic selection/application and verification. And without me doing uml testing, I never got a chance to see the breakage and undo it. I'll definitely add uml to my regular testing. I see hpa has already put this on x86/cleanups, but for the record: Acked-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> Thanks again and sorry for the inconvenience. P. -- > --- > arch/x86/um/vdso/vdso.S | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/um/vdso/vdso.S b/arch/x86/um/vdso/vdso.S > index 4b4bd4c..1cb468a 100644 > --- a/arch/x86/um/vdso/vdso.S > +++ b/arch/x86/um/vdso/vdso.S > @@ -1,3 +1,4 @@ > +#include <linux/init.h> > > __INITDATA > > -- > 1.8.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|