Re: [PATCH] um, x86: Fix vDSO build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/12/2014 06:52 AM, Richard Weinberger wrote:
> Commit "x86: Delete non-required instances of include <linux/init.h>"
> broke the UML build.
> 
> arch/x86/um/vdso/vdso.S: Assembler messages:
> arch/x86/um/vdso/vdso.S:2: Error: no such instruction: `__initdata'
> arch/x86/um/vdso/vdso.S:9: Error: no such instruction: `__finit'
> 
> UML's vDSO needs linux/init.h.
> 
> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> ---
>  arch/x86/um/vdso/vdso.S | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/um/vdso/vdso.S b/arch/x86/um/vdso/vdso.S
> index 4b4bd4c..1cb468a 100644
> --- a/arch/x86/um/vdso/vdso.S
> +++ b/arch/x86/um/vdso/vdso.S
> @@ -1,3 +1,4 @@
> +#include <linux/init.h>
>  
>  __INITDATA
>  

So more bits that got "cleaned up" but never actually tested.  Sigh.

Fengguang, could we get UM builds added to the test robot?

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Stable Commits]     [Linux Stable Kernel]     [Linux Kernel]     [Linux USB Devel]     [Linux Video &Media]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux