On Fri, Nov 22, 2013 at 09:00:54PM -0800, Yinghai Lu wrote: > On Fri, Nov 22, 2013 at 4:07 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote: > > And I suppose a kernel before > > > > 863bffc80898 ("sched/fair: Fix group power_orig computation") > > > > work fine, eh? > > > > I'll further assume that your RIP points to: > > > > sds.avg_load = (SCHED_POWER_SCALE * sds.total_load) / sds.total_pwr; > > > > indicating that sds.total_pwr := 0. > > > > update_sd_lb_stats() computes it like: > > > > sds->total_pwr += sgs->group_power; > > > > which comes out of update_sg_lb_stats() like: > > > > sgs->group_power = group->sgp->power; > > > > Which we compute in update_group_power() similarly to how we did before > > 863bffc80898. > > > > Which leaves me a bit puzzled. > > Hi, > for linus tree i need to revert commit-863bffc. > commit-863bffc > > for linus tree + sched/urgent, I need to revert > commit-42eb088 > commit-9abf24d > commit-863bffc > . > If only revert commit-42eb088, still have problem. > if only revert commit-9abf24d, commit-863bffc, still have problem. > > Assume you need to dump sched/urgent, > and revert commit-863bffc directly from Linus's tree. That doesn't answer any of the questions above and only raises more questions. I also will not revert until a little later, I really need to understand this. My wsm-ep system boots just fine, so there's something funny somewhere. I also cannot see the difference between 863bffc^1 and 9abf24d. Also, you mentioning 42eb088 is new; what does that have to do with anything? You cannot revert that without also reverting 37dc6b50cee9, but you don't mention that commit at all. -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html