On Fri, May 31, 2013 at 02:59:20PM -0700, tip-bot for Jacob Shin wrote: > Commit-ID: 6b3389ac21b5e557b957f1497d0ff22bf733e8c3 > Gitweb: http://git.kernel.org/tip/6b3389ac21b5e557b957f1497d0ff22bf733e8c3 > Author: Jacob Shin <jacob.shin@xxxxxxx> > AuthorDate: Fri, 31 May 2013 01:53:24 -0500 > Committer: H. Peter Anvin <hpa@xxxxxxxxxxxxxxx> > CommitDate: Fri, 31 May 2013 13:56:58 -0700 > > x86, microcode, amd: Fix warnings and errors on with CONFIG_MICROCODE=m > > Fix section mismatch warnings on microcode_amd_early. > Compile error occurs when CONFIG_MICROCODE=m, change so that early > loading depends on microcode_core. > > Reported-by: Yinghai Lu <yinghai@xxxxxxxxxx> > Reported-by: Borislav Petkov <bp@xxxxxxxxx> > Signed-off-by: Jacob Shin <jacob.shin@xxxxxxx> > Link: http://lkml.kernel.org/r/20130531150241.GA12006@jshin-Toonie > Signed-off-by: H. Peter Anvin <hpa@xxxxxxxxxxxxxxx> > --- > arch/x86/Kconfig | 2 +- > arch/x86/include/asm/microcode_amd.h | 2 +- > arch/x86/kernel/microcode_amd_early.c | 8 ++++---- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 28dba52..2705532 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -1065,7 +1065,7 @@ config MICROCODE_AMD_EARLY > > config MICROCODE_EARLY > bool "Early load microcode" > - depends on (MICROCODE_INTEL || MICROCODE_AMD) && BLK_DEV_INITRD > + depends on MICROCODE=y && BLK_DEV_INITRD This means now though, distros will have to build in microcode support (not a module anymore) in order to get early ucode loading support. I'm not saying this is necessarily a bad thing - actually, I even think we want to make the microcode glue in the kernel not be a module anymore because it doesn't hurt and modern CPUs will definitely rather need microcode than not, so we'd need that functionality unconditionally... Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|