I confirmed that efi_pstore_read() and efi_pstore_erase() work correctly. Please feel free to add Tested-by: Seiji Aguchi <seiji.aguchi@xxxxxxx> > -----Original Message----- > From: Matt Fleming [mailto:matt.fleming@xxxxxxxxx] > Sent: Tuesday, April 30, 2013 7:28 AM > To: Seiji Aguchi > Cc: linux-kernel@xxxxxxxxxxxxxxx; mingo@xxxxxxxxxx; hpa@xxxxxxxxx; mjg59@xxxxxxxxxxxxx; tony.luck@xxxxxxxxx; jk@xxxxxxxxxx; > teg@xxxxxxx; tglx@xxxxxxxxxxxxx; mikew@xxxxxxxxxx; linux-tip-commits@xxxxxxxxxxxxxxx > Subject: Re: [tip:x86/efi2] efivars: efivar_entry API > > On 26/04/13 16:43, Seiji Aguchi wrote: > > I tested pstore_read() as well. > > And /dev/pstore/dmesg-efi-X was empty.... > > > > This must be __efivar_entry_get() instead of __efivar_entry_size(). > > (We may have to introduce _efivar_entry_get_locked() to avoid deadlock.) > > > > I think it is a final bug report related to this new API patch. > > Can you try the 'efi-for-tip-fixes' branch at, > > git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/efi.git > > and see if your problems are solved? ��.n��������+%������w��{.n�����{��ة��)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥