[tip:perf/core] uprobes: Kill the unnecesary filp != NULL check in __copy_insn()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Commit-ID:  98763a1bb1515f8a8d7f1d9ae42604e19872364b
Gitweb:     http://git.kernel.org/tip/98763a1bb1515f8a8d7f1d9ae42604e19872364b
Author:     Oleg Nesterov <oleg@xxxxxxxxxx>
AuthorDate: Sun, 24 Mar 2013 18:45:44 +0100
Committer:  Oleg Nesterov <oleg@xxxxxxxxxx>
CommitDate: Thu, 4 Apr 2013 13:57:05 +0200

uprobes: Kill the unnecesary filp != NULL check in __copy_insn()

__copy_insn(filp) can only be called after valid_vma() returns T,
vma->vm_file passed as "filp" can not be NULL.

Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
Acked-by: Anton Arapov <anton@xxxxxxxxxx>
Acked-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>
---
 kernel/events/uprobes.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index ba6acfe..0938665 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -501,9 +501,6 @@ __copy_insn(struct address_space *mapping, struct file *filp, char *insn,
 {
 	struct page *page;
 
-	if (!filp)
-		return -EINVAL;
-
 	if (!mapping->a_ops->readpage)
 		return -EIO;
 	/*
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Stable Commits]     [Linux Stable Kernel]     [Linux Kernel]     [Linux USB Devel]     [Linux Video &Media]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux