Re: [RFC PATCH 1/2] ipc: introduce obtaining a lockless ipc object
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [RFC PATCH 1/2] ipc: introduce obtaining a lockless ipc object
- From: Rik van Riel <riel@xxxxxxxxxx>
- Date: Sat, 02 Mar 2013 21:18:35 -0500
- Cc: Davidlohr Bueso <davidlohr.bueso@xxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, "Vinod, Chegu" <chegu_vinod@xxxxxx>, "Low, Jason" <jason.low2@xxxxxx>, linux-tip-commits@xxxxxxxxxxxxxxx, Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, aquini@xxxxxxxxxx, Ingo Molnar <mingo@xxxxxxxxxx>, Larry Woodman <lwoodman@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>
- In-reply-to: <CANN689EqgPZVw=Sy_WAkB+=MJJCZeRMq_CmF1gec+cRVCS2xtA@mail.gmail.com>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2
On 03/01/2013 11:32 PM, Michel Lespinasse wrote:
I think it may be nicer to take the rcu read lock at the call site
rather than in ipc_obtain_object(), to make the rcu read lock/unlock
sites pair up more nicely. Either that or make an inline
ipc_release_object function that pairs up with ipc_obtain_object() and
just does an rcu_read_unlock().
I started on a patch series to untangle the IPC locking, so
it will be a little more readable, and easier to maintain.
It is a slower approach than Davidlohr's, as in, it will take
a little longer to put a patch series together, but I hope it
will be easier to debug...
I hope to post a first iteration of the series by the middle
of next week.
--
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]