Commit-ID: 94a193fb7393a50625abd9ca21f8afea275a9f87 Gitweb: http://git.kernel.org/tip/94a193fb7393a50625abd9ca21f8afea275a9f87 Author: Matt Fleming <matt.fleming@xxxxxxxxx> AuthorDate: Fri, 11 Jan 2013 13:30:46 +0000 Committer: Matt Fleming <matt.fleming@xxxxxxxxx> CommitDate: Thu, 31 Jan 2013 14:44:44 +0000 efivarfs: Use sizeof() instead of magic number Instead of adding a magic 4 to the variable size, use sizeof() to make it explicitly clear what the quantity represents (the variable's attributes). CC: Jeremy Kerr <jeremy.kerr@xxxxxxxxxxxxx> Cc: Chun-Yi Lee <joeyli.kernel@xxxxxxxxx> Cc: Andy Whitcroft <apw@xxxxxxxxxxxxx> Reported-by: Lingzhu Xiang <lxiang@xxxxxxxxxx> Signed-off-by: Matt Fleming <matt.fleming@xxxxxxxxx> --- drivers/firmware/efivars.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c index f5596db..371c441 100644 --- a/drivers/firmware/efivars.c +++ b/drivers/firmware/efivars.c @@ -1076,7 +1076,7 @@ static int efivarfs_fill_super(struct super_block *sb, void *data, int silent) mutex_lock(&inode->i_mutex); inode->i_private = entry; - i_size_write(inode, size+4); + i_size_write(inode, size + sizeof(entry->var.Attributes)); mutex_unlock(&inode->i_mutex); d_add(dentry, inode); } -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|