Commit-ID: af4355e91f15812df8608925738c91be57c580dd Gitweb: http://git.kernel.org/tip/af4355e91f15812df8608925738c91be57c580dd Author: Oleg Nesterov <oleg@xxxxxxxxxx> AuthorDate: Mon, 31 Dec 2012 18:37:11 +0100 Committer: Oleg Nesterov <oleg@xxxxxxxxxx> CommitDate: Fri, 8 Feb 2013 17:47:13 +0100 uprobes: Kill the bogus IS_ERR_VALUE(xol_vaddr) check utask->xol_vaddr is either zero or valid, remove the bogus IS_ERR_VALUE() check in xol_free_insn_slot(). Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx> Acked-by: Anton Arapov <anton@xxxxxxxxxx> Acked-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx> --- kernel/events/uprobes.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index 071edcb..f6c7062 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -1223,8 +1223,7 @@ static void xol_free_insn_slot(struct task_struct *tsk) return; slot_addr = tsk->utask->xol_vaddr; - - if (unlikely(!slot_addr || IS_ERR_VALUE(slot_addr))) + if (unlikely(!slot_addr)) return; area = tsk->mm->uprobes_state.xol_area; -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|