Commit-ID: e8932fd96c560762530474cd0d2702f031b0de5e Gitweb: http://git.kernel.org/tip/e8932fd96c560762530474cd0d2702f031b0de5e Author: Michael Ellerman <michael@xxxxxxxxxxxxxx> AuthorDate: Wed, 6 Feb 2013 19:19:14 +1100 Committer: Pekka Enberg <penberg@xxxxxxxxxx> CommitDate: Wed, 6 Feb 2013 13:05:24 +0200 kvm tools: powerpc: Fix buglet in xics_init() handling of nrcpus In xics_init() we set the maximum server to kvm->nrcpus, and then set the nr_servers using maximum server + 1. That is off by one, in the harmless direction. Simplify it to just set nr_servers = kvm->nrcpus. Signed-off-by: Michael Ellerman <michael@xxxxxxxxxxxxxx> Signed-off-by: Pekka Enberg <penberg@xxxxxxxxxx> --- tools/kvm/powerpc/xics.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/kvm/powerpc/xics.c b/tools/kvm/powerpc/xics.c index d4b5caa..cf64a08 100644 --- a/tools/kvm/powerpc/xics.c +++ b/tools/kvm/powerpc/xics.c @@ -445,16 +445,13 @@ static void rtas_int_on(struct kvm_cpu *vcpu, uint32_t token, static int xics_init(struct kvm *kvm) { - int max_server_num; unsigned int i; struct icp_state *icp; struct ics_state *ics; int j; - max_server_num = kvm->nrcpus; - icp = malloc(sizeof(*icp)); - icp->nr_servers = max_server_num + 1; + icp->nr_servers = kvm->nrcpus; icp->ss = malloc(icp->nr_servers * sizeof(struct icp_server_state)); for (i = 0; i < icp->nr_servers; i++) { -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |