Commit-ID: 1fa7e6958c5f82cc75c594e3ffaf73cc26fc94c1 Gitweb: http://git.kernel.org/tip/1fa7e6958c5f82cc75c594e3ffaf73cc26fc94c1 Author: Matt Fleming <matt.fleming@xxxxxxxxx> AuthorDate: Wed, 16 Jan 2013 13:47:05 +0000 Committer: Matt Fleming <matt.fleming@xxxxxxxxx> CommitDate: Fri, 18 Jan 2013 09:43:44 +0000 efivarfs: Never return ENOENT from firmware Files are created in efivarfs_create() before a corresponding variable is created in the firmware. This leads to users being able to read/write to the file without the variable existing in the firmware. Reading a non-existent variable currently returns -ENOENT, which is confusing because the file obviously *does* exist. Convert EFI_NOT_FOUND into -EIO which is the closest thing to "error while interacting with firmware", and should hopefully indicate to the caller that the variable is in some uninitialised state. Cc: Josh Boyer <jwboyer@xxxxxxxxxx> Acked-by: Jeremy Kerr <jeremy.kerr@xxxxxxxxxxxxx> Cc: Lee, Chun-Yi <jlee@xxxxxxxx> Cc: Andy Whitcroft <apw@xxxxxxxxxxxxx> Reported-by: Lingzhu Xiang <lxiang@xxxxxxxxxx> Signed-off-by: Matt Fleming <matt.fleming@xxxxxxxxx> --- drivers/firmware/efivars.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c index fa9fa03..807dad4 100644 --- a/drivers/firmware/efivars.c +++ b/drivers/firmware/efivars.c @@ -674,7 +674,7 @@ static int efi_status_to_err(efi_status_t status) err = -EACCES; break; case EFI_NOT_FOUND: - err = -ENOENT; + err = -EIO; break; default: err = -EINVAL; -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|