[tip:tools/kvm] kvm tools: avoid linking dynamically against libbfd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Commit-ID:  fd4fae8728cb593c09f3b9e06a871275ecc34720
Gitweb:     http://git.kernel.org/tip/fd4fae8728cb593c09f3b9e06a871275ecc34720
Author:     Will Deacon <will.deacon@xxxxxxx>
AuthorDate: Mon, 12 Nov 2012 11:57:17 +0000
Committer:  Pekka Enberg <penberg@xxxxxxxxxx>
CommitDate: Tue, 13 Nov 2012 09:23:57 +0200

kvm tools: avoid linking dynamically against libbfd

Linking dynamically against libbfd results in a non-portable application
binary and is generally frowned upon by distributions: Debian forbids it
explicitly and on Gentoo, it results in a failure at run-time:

  ./lkvm: error while loading shared libraries: libbfd-2.22.so: cannot
  open shared object file: No such file or directory

Avoid these problems by linking statically instead.

Signed-off-by: Will Deacon <will.deacon@xxxxxxx>
Signed-off-by: Pekka Enberg <penberg@xxxxxxxxxx>
---
 tools/kvm/Makefile | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/tools/kvm/Makefile b/tools/kvm/Makefile
index 23a7c40..44a55c2 100644
--- a/tools/kvm/Makefile
+++ b/tools/kvm/Makefile
@@ -171,11 +171,6 @@ endif
 # both and only build those that link!
 
 FLAGS_BFD := $(CFLAGS) -lbfd
-ifeq ($(call try-cc,$(SOURCE_BFD),$(FLAGS_BFD)),y)
-	CFLAGS_DYNOPT	+= -DCONFIG_HAS_BFD
-	OBJS_DYNOPT	+= symbol.o
-	LIBS_DYNOPT	+= -lbfd
-endif
 ifeq ($(call try-cc,$(SOURCE_BFD),$(FLAGS_BFD) -static),y)
 	CFLAGS_STATOPT	+= -DCONFIG_HAS_BFD
 	OBJS_STATOPT	+= symbol.o
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Stable Commits]     [Linux Stable Kernel]     [Linux Kernel]     [Linux USB Devel]     [Linux Video &Media]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux