Commit-ID: 78fb84e8553222b1b47afa76e1ccbc9fadb9d824 Gitweb: http://git.kernel.org/tip/78fb84e8553222b1b47afa76e1ccbc9fadb9d824 Author: Ingo Molnar <mingo@xxxxxxxxxx> AuthorDate: Thu, 6 Dec 2012 14:24:48 +0100 Committer: Ingo Molnar <mingo@xxxxxxxxxx> CommitDate: Fri, 7 Dec 2012 00:17:27 +0100 numa, sched: Fix NUMA tick ->numa_shared setting Split out an unlocked variant of __sched_setnuma(), and use it in the NUMA tick when we are modifying p->numa_shared. Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> Cc: Andrea Arcangeli <aarcange@xxxxxxxxxx> Cc: Rik van Riel <riel@xxxxxxxxxx> Cc: Mel Gorman <mgorman@xxxxxxx> Cc: Hugh Dickins <hughd@xxxxxxxxxx> Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx> --- kernel/sched/core.c | 19 +++++++++++++++---- kernel/sched/fair.c | 2 +- kernel/sched/sched.h | 1 + 3 files changed, 17 insertions(+), 5 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 69b18b3..cce84c3 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -6091,13 +6091,10 @@ static struct sched_domain_topology_level *sched_domain_topology = default_topol /* * Change a task's NUMA state - called from the placement tick. */ -void sched_setnuma(struct task_struct *p, int node, int shared) +void __sched_setnuma(struct rq *rq, struct task_struct *p, int node, int shared) { - unsigned long flags; int on_rq, running; - struct rq *rq; - rq = task_rq_lock(p, &flags); on_rq = p->on_rq; running = task_current(rq, p); @@ -6113,6 +6110,20 @@ void sched_setnuma(struct task_struct *p, int node, int shared) p->sched_class->set_curr_task(rq); if (on_rq) enqueue_task(rq, p, 0); +} + +/* + * Change a task's NUMA state - called from the placement tick. + */ +void sched_setnuma(struct task_struct *p, int node, int shared) +{ + unsigned long flags; + struct rq *rq; + + rq = task_rq_lock(p, &flags); + + __sched_setnuma(rq, p, node, shared); + task_rq_unlock(rq, p, &flags); /* diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 21c10f7..0c83689 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2540,7 +2540,7 @@ static void task_tick_numa(struct rq *rq, struct task_struct *curr) /* Cheap checks first: */ if (!task_numa_candidate(curr)) { if (curr->numa_shared >= 0) - curr->numa_shared = -1; + __sched_setnuma(rq, curr, -1, -1); return; } diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 0fdd304..f75bf06 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -513,6 +513,7 @@ DECLARE_PER_CPU(struct rq, runqueues); #define raw_rq() (&__raw_get_cpu_var(runqueues)) #ifdef CONFIG_NUMA_BALANCING +extern void __sched_setnuma(struct rq *rq, struct task_struct *p, int node, int shared); extern void sched_setnuma(struct task_struct *p, int node, int shared); static inline void task_numa_free(struct task_struct *p) { -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html