Commit-ID: aeeaa8d46aa38c9cc5fac23feb9b1f91bdbf5dd3
Gitweb: http://git.kernel.org/tip/aeeaa8d46aa38c9cc5fac23feb9b1f91bdbf5dd3
Author: Matt Fleming <matt.fleming@xxxxxxxxx>
AuthorDate: Tue, 23 Oct 2012 12:41:03 +0100
Committer: Matt Fleming <matt.fleming@xxxxxxxxx>
CommitDate: Tue, 30 Oct 2012 10:39:28 +0000
efivarfs: Return a consistent error when efivarfs_get_inode() fails
Instead of returning -ENOSPC if efivarfs_get_inode() fails we should
be returning -ENOMEM, since running out of memory is the only reason
it can fail. Furthermore, that's the error value used everywhere else
in this file. It's also less likely to confuse users that hit this
error case.
Acked-by: Jeremy Kerr <jeremy.kerr@xxxxxxxxxxxxx>
Signed-off-by: Matt Fleming <matt.fleming@xxxxxxxxx>
---
drivers/firmware/efivars.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index 6a858d1..58cec62 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers/firmware/efivars.c
@@ -911,7 +911,7 @@ static int efivarfs_create(struct inode *dir, struct dentry *dentry,
inode = efivarfs_get_inode(dir->i_sb, dir, mode, 0);
if (!inode)
- return -ENOSPC;
+ return -ENOMEM;
var = kzalloc(sizeof(struct efivar_entry), GFP_KERNEL);
if (!var) {
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|