Re: [tip:tools/kvm] kvm tools: Fix reported year in RTC emulation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On 10/19/2012 01:17 PM, ron minnich wrote:
> > I'm embarrassed, the comment matcheth not the code. Oops.
> > 
> > "if year is > 99, subtract 100 etc."
> > 
> > Or just yank all my words starting with "If the year ..."
> > 
> > Sorry. I'll never make this mistake again, at least until we run out
> > of BCD digits.
> > 

On Fri, 19 Oct 2012, H. Peter Anvin wrote:
> You know there is a century field, right?

Unfortunately we don't support ACPI and looking at 
arch/x86/kernel/rtc.c::mach_get_cmos_time(), I think we'd need that to 
tell the guest kernel which register is used for the century field:

#ifdef CONFIG_ACPI
        if (acpi_gbl_FADT.header.revision >= FADT2_REVISION_ID &&
            acpi_gbl_FADT.century)
                century = CMOS_READ(acpi_gbl_FADT.century);
#endif

			Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Stable Commits]     [Linux Stable Kernel]     [Linux Kernel]     [Linux USB Devel]     [Linux Video &Media]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux