* Ido Yariv <ido@xxxxxxxxxx> wrote: > Hi Ingo, > > On Tue, May 08, 2012 at 02:25:49PM +0200, Ingo Molnar wrote: > > > > On !CONFIG_SMP this produces the following build failure: > > > > arch/x86/kernel/vsmp_64.c:171:6: error: ‘setup_max_cpus’ undeclared (first use in this function) > > > > Do you want to keep vSMP on UP? If not then you could add a > > 'depends on SMP' to the vSMP Kconfig entry, avoiding the whole > > UP problem space. > > Oops, sorry for that. > > vsmp_64.c is built even if CONFIG_X86_VSMP is not set, so even > if we set this dependency, it will not fix this issue. Well, then fix the Makefile rule as well. Is there any point to using vSMP specific glue on UP kernels? > How about the following CONFIG_SMP check instead? Looks pretty ugly, because it just increases the config jungle instead of reducing it. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|