Re: [PATCH 1/2] boot: ignore early NMIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 1/2] boot: ignore early NMIs
From: Fernando Luis Vázquez Cao <fernando@xxxxxxxxxxxxx>
Date: Fri, 09 Mar 2012 18:31:17 +0900
Cc: Don Zickus <dzickus@xxxxxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx, Yinghai Lu <yinghai@xxxxxxxxxx>, kexec@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, mingo@xxxxxxxxxx, hpa@xxxxxxxxx, tglx@xxxxxxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, mingo@xxxxxxx, vgoyal@xxxxxxxxxx
In-reply-to: <m1r4x3yrsv.fsf@fess.ebiederm.org>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2

On 03/09/2012 01:35 AM, Eric W. Biederman wrote:

I am fine with your approach.  I suggest a big fat comment mentioning
the 10 byte requirement and the register requirement.

Neither one is locally obvious which makes it easy to goof when
modifying the code.

Done.

Doing something less brittle than:

extern const char early_idt_handlers[NUM_EXCEPTION_VECTORS][10];

in segment.h might be a good idea as well.

Tackled that one too.

I will be replying to this email with the updated patches.

Thanks,
Fernando

--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Follow-Ups:
- [PATCH 1/3] boot: fortify early_idt_handlers definition
  - From: Fernando Luis Vázquez Cao

References:
- Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path
  - From: Yinghai Lu
- Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path
  - From: Don Zickus
- Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path
  - From: Yinghai Lu
- Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path
  - From: Don Zickus
- Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path
  - From: Eric W. Biederman
- Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path
  - From: Eric W. Biederman
- Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path
  - From: Don Zickus
- Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path
  - From: Eric W. Biederman
- Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path
  - From: Don Zickus
- Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path
  - From: Eric W. Biederman
- Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path
  - From: Don Zickus
- Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path
  - From: Eric W. Biederman
- Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path
  - From: Fernando Luis Vázquez Cao
- [PATCH 1/2] boot: ignore early NMIs
  - From: Fernando Luis Vázquez Cao
- Re: [PATCH 1/2] boot: ignore early NMIs
  - From: Eric W. Biederman
- Re: [PATCH 1/2] boot: ignore early NMIs
  - From: Fernando Luis Vázquez Cao
- Re: [PATCH 1/2] boot: ignore early NMIs
  - From: Eric W. Biederman

Prev by Date: Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path
Next by Date: [PATCH 1/3] boot: fortify early_idt_handlers definition
Previous by thread: Re: [PATCH 1/2] boot: ignore early NMIs
Next by thread: [PATCH 1/3] boot: fortify early_idt_handlers definition
Index(es):
- Date
- Thread

[Index of Archives] [Linux Stable Commits] [Linux Stable Kernel] [Linux Kernel] [Linux USB Devel] [Linux Video &Media] [Linux Audio Users] [Yosemite News] [Linux SCSI]