Re: Re: [tip:perf/core] x86/kprobes: Fix to recover instructions on optimized path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Ingo Molnar <mingo@xxxxxxx> wrote:

> > > Does not build on x86 if CONFIG_OPTPROBES is off:
> > > 
> > > arch/x86/kernel/kprobes.c:260:8: error: dereferencing pointer to incomplete type
> > > arch/x86/kernel/kprobes.c:260:8: error: invalid use of undefined type ‘struct optimized_kprobe’
> > > arch/x86/kernel/kprobes.c:262:22: error: dereferencing pointer to incomplete type
> > > arch/x86/kernel/kprobes.c:264:18: error: dereferencing pointer to incomplete type
> > 
> > Oops, should I update this patch or send new diff?
> 
> Please send a delta fix.

Hm, it was triggering too often so I removed it from perf:core 
for now - please send an updated patch.

Please also pick up the slightly updated changelog I've created 
for the commit - you can see it in the -tip notification email.

Btw., why are optprobes limited to !PREEMPT, could we make them 
preempt safe?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Stable Commits]     [Linux Stable Kernel]     [Linux Kernel]     [Linux USB Devel]     [Linux Video &Media]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux