On Sat, 2012-02-11 at 15:10 -0800, tip-bot for Anton Vorontsov wrote: > +static inline struct sighand_struct *lock_task_sighand(struct task_struct *tsk, > + unsigned long *flags) > +{ > + struct sighand_struct *ret; > + > + ret = __lock_task_sighand(tsk, flags); > + (void)__cond_lock(&tsk->sighand->siglock, ret); > + return ret; > +} FWIW, I still really utterly detest __cond_lock(). Ideally someone would teach sparse the conditional based on return thing and we could do the function level annotation. -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html