[tip:tools/kvm] kvm tools: fix instances enumeration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Commit-ID:  737579f6b7e0653ecec7f09aea3b11ba67a69ccf
Gitweb:     http://git.kernel.org/tip/737579f6b7e0653ecec7f09aea3b11ba67a69ccf
Author:     Konstantin Khlebnikov <khlebnikov@xxxxxxxxxx>
AuthorDate: Sun, 10 Jul 2011 16:13:27 +0400
Committer:  Pekka Enberg <penberg@xxxxxxxxxx>
CommitDate: Sun, 10 Jul 2011 15:21:58 +0300

kvm tools: fix instances enumeration

Calling readdir() with NULL dirp leads to segfault.

Signed-off-by: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxx>
[ penberg@xxxxxxxxxx: use 'while' instead of 'for' ]
Signed-off-by: Pekka Enberg <penberg@xxxxxxxxxx>
---
 tools/kvm/kvm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/kvm/kvm.c b/tools/kvm/kvm.c
index cd3cb19..a4a29b2 100644
--- a/tools/kvm/kvm.c
+++ b/tools/kvm/kvm.c
@@ -172,7 +172,7 @@ int kvm__enumerate_instances(void (*callback)(const char *name, int pid))
 	sprintf(full_name, "%s/%s", HOME_DIR, KVM_PID_FILE_PATH);
 	dir = opendir(full_name);
 
-	for (;;) {
+	while (dir != NULL) {
 		readdir_r(dir, &entry, &result);
 		if (result == NULL)
 			break;
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Stable Commits]     [Linux Stable Kernel]     [Linux Kernel]     [Linux USB Devel]     [Linux Video &Media]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux