Commit-ID: 0c29d3f28d5745f67679659bb8979ae963579c47 Gitweb: http://git.kernel.org/tip/0c29d3f28d5745f67679659bb8979ae963579c47 Author: Sasha Levin <levinsasha928@xxxxxxxxx> AuthorDate: Tue, 5 Jul 2011 12:35:45 +0300 Committer: Pekka Enberg <penberg@xxxxxxxxxx> CommitDate: Tue, 5 Jul 2011 21:58:26 +0300 kvm tools: Clean ghost pid files in 'kvm list' When running 'kvm list', first make sure that the guest process is up and running before printing the entry. Signed-off-by: Sasha Levin <levinsasha928@xxxxxxxxx> Signed-off-by: Pekka Enberg <penberg@xxxxxxxxxx> --- tools/kvm/kvm-list.c | 21 +++++++++++++++++++++ 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/tools/kvm/kvm-list.c b/tools/kvm/kvm-list.c index 696c355..40c0e48 100644 --- a/tools/kvm/kvm-list.c +++ b/tools/kvm/kvm-list.c @@ -6,10 +6,31 @@ #include <stdio.h> #include <string.h> #include <signal.h> +#include <fcntl.h> + +#define PROCESS_NAME "kvm" static void print_guest(const char *name, int pid) { + char proc_name[PATH_MAX]; + char comm[sizeof(PROCESS_NAME)]; + int fd; + + sprintf(proc_name, "/proc/%d/comm", pid); + fd = open(proc_name, O_RDONLY); + if (fd <= 0) + goto cleanup; + if (read(fd, comm, sizeof(PROCESS_NAME)) == 0) + goto cleanup; + if (strncmp(comm, PROCESS_NAME, strlen(PROCESS_NAME))) + goto cleanup; + printf("%s (PID: %d)\n", name, pid); + + return; + +cleanup: + kvm__remove_pidfile(name); } int kvm_cmd_list(int argc, const char **argv, const char *prefix) -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |