Re: [debug patch] printk: Add a printk killswitch to robustify NMI watchdog messages
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [debug patch] printk: Add a printk killswitch to robustify NMI watchdog messages
- From: Ingo Molnar <mingo@xxxxxxx>
- Date: Mon, 6 Jun 2011 17:52:36 +0200
- Cc: Arne Jansen <lists@xxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, mingo@xxxxxxxxxx, hpa@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, efault@xxxxxx, npiggin@xxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, frank.rowand@xxxxxxxxxxx, tglx@xxxxxxxxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx
- In-reply-to: <1307375227.2322.161.camel@twins>
- User-agent: Mutt/1.5.20 (2009-08-17)
* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> Needs more staring at, preferably by someone who actually
> understands that horrid mess :/ Also, this all still doesn't make
> printk() work reliably while holding rq->lock.
So, what about my suggestion to just *remove* the wakeup from there
and use the deferred wakeup mechanism that klogd uses.
That would make printk() *visibly* more robust in practice.
[ It would also open up the way to possibly make printk() NMI entry
safe - currently we lock up if we printk in an NMI or #MC context
that happens to nest inside a printk(). ]
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]