Re: [tip:core/urgent] WARN_ON_SMP(): Allow use in if() statements on UP
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:core/urgent] WARN_ON_SMP(): Allow use in if() statements on UP
- From: Alexey Dobriyan <adobriyan@xxxxxxxxx>
- Date: Fri, 25 Mar 2011 21:47:29 +0200
- Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, mingo@xxxxxxxxxx, hpa@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, dvhart@xxxxxxxxxxxxxxx, peterz@xxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, srostedt@xxxxxxxxxx, tglx@xxxxxxxxxxxxx, laijs@xxxxxxxxxxxxxx, mingo@xxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx
- In-reply-to: <1301082034.14261.202.camel@xxxxxxxxxxxxxxxxxxx>
- User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Mar 25, 2011 at 03:40:34PM -0400, Steven Rostedt wrote:
> On Fri, 2011-03-25 at 21:31 +0200, Alexey Dobriyan wrote:
>
> > > Would you like me to add a comment that states:
> > >
> > > /*
> > > * Use ({0;}) as just "0" will cause gcc to output:
> > > * warning: statement with no effect
> > > */
> >
> > Try ((void)0)
>
> Maybe I should update the comment to stop further confusion:
Ah!
I always thought if (WARN_ON(x)) is confusing and should be banned.
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]