Commit-ID: 1396fa9cd2e34669253b7ca8c75f12103481f71c Gitweb: http://git.kernel.org/tip/1396fa9cd2e34669253b7ca8c75f12103481f71c Author: Dan Carpenter <error27@xxxxxxxxx> AuthorDate: Fri, 18 Feb 2011 12:17:16 +0300 Committer: Ingo Molnar <mingo@xxxxxxx> CommitDate: Sun, 20 Feb 2011 14:01:32 +0100 x86, microcode, AMD: Fix signedness bug in generic_load_microcode() install_equiv_cpu_table() returns type int. It uses negative error codes so using an unsigned type breaks the error handling. Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> Acked-by: Borislav Petkov <borislav.petkov@xxxxxxx> Cc: open list:AMD MICROCODE UPD... <amd64-microcode@xxxxxxxxx> Cc: Andreas Herrmann <andreas.herrmann3@xxxxxxx> LKML-Reference: <20110218091716.GA4384@bicker> Signed-off-by: Ingo Molnar <mingo@xxxxxxx> --- arch/x86/kernel/microcode_amd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c index 9fb8405..c561038 100644 --- a/arch/x86/kernel/microcode_amd.c +++ b/arch/x86/kernel/microcode_amd.c @@ -246,7 +246,7 @@ generic_load_microcode(int cpu, const u8 *data, size_t size) struct ucode_cpu_info *uci = ucode_cpu_info + cpu; struct microcode_header_amd *mc_hdr = NULL; unsigned int mc_size, leftover; - unsigned long offset; + int offset; const u8 *ucode_ptr = data; void *new_mc = NULL; unsigned int new_rev = uci->cpu_sig.rev; -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|