On Wed, 2011-02-09 at 14:41 -0200, Arnaldo Carvalho de Melo wrote: > Em Wed, Feb 09, 2011 at 05:06:18AM +0100, Mike Galbraith escreveu: > > On Wed, 2011-02-09 at 00:43 +0000, tip-bot for Arnaldo Carvalho de Melo wrote > > > Gitweb: http://git.kernel.org/tip/d5e3d747007fdb541e57ed72e020ff0b94db3470 > > > Author: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> > > > > > > perf annotate: Fix annotate context lines regression > > > > > > The live annotation done in 'perf top' needs to limit the context before > > > lines that aren't filtered out by the min percent filter, if we don't do > > > that, the screen in a tty often is not enough for showing what is > > > interesting: lines with hits and a few source code lines before it. > > > > Looks to me like this went from regress a bit while waiting for tui > > thing to progress a bit immediately :) > > :-) Can you please apply the two patches and give 'perf top --tui' live > annotation a shot? Just press enter or -> (right key) on a symbol you > want to annotate. > > I'm still polishing it a bit, want to avoid trying the notes->lock on > each time record_precise_ip is called, for that I need to share the > current symbol being annotated (sym_filter_entry) with the annotate > browser, the timer should not always run, etc, but just so that I can > get some feedback on how it is shaping up, please try it and report your > impressions :-) Initial impression: can I have a pony too? :) I like this a lot, great for live rummaging. One thing that would help with large files maybe - a jump to next spot hotter than N%, but as is is quite nice. I managed to lock it up once, but shiny new gizmos usually do hiccup. -Mike -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|