Commit-ID: cbcf14a942eb06d031628046739b983e84b383bf
Gitweb: http://git.kernel.org/tip/cbcf14a942eb06d031628046739b983e84b383bf
Author: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
AuthorDate: Tue, 17 Aug 2010 13:36:40 +0300
Committer: Michal Marek <mmarek@xxxxxxx>
CommitDate: Thu, 26 Aug 2010 13:55:23 +0200
scripts/mod/modpost.c: fix commentary accordingly to last changes
The last commits
37ed19d5cce35a40d3913cf9aa208ce9f60db3d7
5003bab82d56754b27be01eef24495a02e00039d
have introduced new behaviour of sec2annotation() method. However, the
commentary inside the method was left as before. Let's fix it accordingly.
Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@xxxxxxxxx>
Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Acked-by: WANG Cong <xiyou.wangcong@xxxxxxxxx>
Signed-off-by: Michal Marek <mmarek@xxxxxxx>
---
scripts/mod/modpost.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index c827309..859bee4 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1193,6 +1193,9 @@ static Elf_Sym *find_elf_symbol2(struct elf_info *elf, Elf_Addr addr,
* .cpuinit.data => __cpudata
* .memexitconst => __memconst
* etc.
+ *
+ * The memory of returned value has been allocated on a heap. The user of this
+ * method should free it after usage.
*/
static char *sec2annotation(const char *s)
{
@@ -1215,7 +1218,7 @@ static char *sec2annotation(const char *s)
strcat(p, "data ");
else
strcat(p, " ");
- return r; /* we leak her but we do not care */
+ return r;
} else {
return "";
}
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|