On Fri, Oct 29, 2010 at 10:58:03PM +0200, Eric Dumazet wrote: > Le samedi 30 octobre 2010 à 00:28 +0400, Cyrill Gorcunov a écrit : > > On Fri, Oct 29, 2010 at 08:32:26PM +0200, Peter Zijlstra wrote: > > > On Fri, 2010-10-29 at 06:43 +0000, tip-bot for Eric Dumazet wrote: > > > > + irqctx = page_address(alloc_pages_node(cpu_to_node(cpu), > > > > + THREAD_FLAGS, > > > > + THREAD_ORDER)); > > > > > > Shouldn't we be checking for a NULL return from alloc_pages_node() > > > before calling page_address() on it? > > > -- > > > > Something like below I guess, but probably we could try to allocate > > on appropriate NUMA node first and if it fails -- via old alloc_pages > > and if it fail in turn -- then we panic. > > Maybe my commit message was not clear : > > There is no need to test return from alloc_pages_node() and do the > fallback. It already done properly. > Yes Eric, somehow managed to miss that, my bad. Cyrill -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|