On Fri, Oct 29, 2010 at 08:32:26PM +0200, Peter Zijlstra wrote: > On Fri, 2010-10-29 at 06:43 +0000, tip-bot for Eric Dumazet wrote: > > + irqctx = page_address(alloc_pages_node(cpu_to_node(cpu), > > + THREAD_FLAGS, > > + THREAD_ORDER)); > > Shouldn't we be checking for a NULL return from alloc_pages_node() > before calling page_address() on it? It seems at this stage it's a panic() or BUG_ON candidate. (Which reminds me GFP_PANIC flag proposal back in 2009 ;) Cyrill -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html