Thomas Gleixner Tue, 12 Oct 2010 23:28:19 +0200 (CEST) >On Tue, 12 Oct 2010, Jacob Pan wrote: > >> >> >x86: Sanitize apb timer interrupt handling >> > >> >Disable the interrupt in CPU_DEAD where it belongs. >> My main concern is the performance cost. The power management code for >> Moorestown system make use of the cpu hotplug code (disable_nonboot_cpus) >> but much more frequently. The system low power states are call S0 idle >> state (s0ix). >> >> Leaving the irq enabled at the chip and desc level between S0ix states >> might give some performance benefit. That was my original thought. >> Will it cause problems? > >Errm. I merily moved it to the place where it should be. You do the >disable/enable dance already today. > I think I only do disable/enable at the timer HW level today during cpu hp notification, not calling disable_irq(). Am i missing something? Thanks, Jacob -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|