* Pan, Jacob jun <jacob.jun.pan@xxxxxxxxx> wrote: > +static struct irq_chip dummy_pic_chip = { > + .name = "dummy pic", > + .mask = legacy_pic_uint_noop, > + .unmask = legacy_pic_uint_noop, > + .disable = legacy_pic_uint_noop, > + .mask_ack = legacy_pic_uint_noop, > +}; > +static int legacy_pic_irq_pending_noop(unsigned int irq) > +{ > + return 0; > +} > + > +struct legacy_pic null_legacy_pic = { > + .nr_legacy_irqs = 0, > + .chip = &dummy_pic_chip, > + .mask_all = legacy_pic_noop, > + .restore_mask = legacy_pic_noop, > + .init = legacy_pic_int_noop, > + .irq_pending = legacy_pic_irq_pending_noop, > + .make_irq = legacy_pic_uint_noop, > +}; > + > +struct legacy_pic default_legacy_pic = { > + .nr_legacy_irqs = NR_IRQS_LEGACY, > + .chip = &i8259A_chip, > + .mask_all = mask_8259A, > + .restore_mask = unmask_8259A, > + .init = init_8259A, > + .irq_pending = i8259A_irq_pending, > + .make_irq = make_8259A_irq, > +}; Just a reminder: please use the vertical alignment style you can see with new pic/irqchip drivers: struct irq_chip i8259A_chip = { .name = "XT-PIC", .mask = disable_8259A_irq, .disable = disable_8259A_irq, .unmask = enable_8259A_irq, .mask_ack = mask_and_ack_8259A, }; Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |