Re: [tip:perf/core] bitops: Provide compile time HWEIGHT{8,16,32,64}
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:perf/core] bitops: Provide compile time HWEIGHT{8,16,32,64}
- From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
- Date: Fri, 29 Jan 2010 08:24:31 -0800 (PST)
- Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, mingo@xxxxxxxxxx, hpa@xxxxxxxxx, eranian@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx
- In-reply-to: <1264763023.4283.2213.camel@laptop>
- References: <20100122155535.797688466@xxxxxxxxx> <tip-9f41699ed067fa695faff8e2e9981b2550abec62@xxxxxxxxxxxxxx> <20100129020128.716af8fb.akpm@xxxxxxxxxxxxxxxxxxxx> <1264763023.4283.2213.camel@laptop>
- User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Fri, 29 Jan 2010, Peter Zijlstra wrote:
>
> *sigh* and here I though it being placed right next to hweight_long()
> which uses the arch hweightN() would be clue enough.
No. People who add new uses may be copying old uses, without looking at
the definition.
Also, people who _change_ uses may be changing a value that used to be a
constant into a variable when something is made more dynamic. At which
point it really makes sense to have a function that requires a constant to
_check_ that it gets a constant.
> If people are so clueless, who says they'll read a comment.. but sure I
> guess I can add one.
The comment nobody cares about. But surprisingly crap code generation?
That's bad.
> Subject: bitops: Dummyify the compile-time hweight versions
>
> Because it seems allowed to not think and write kernel code.
I would suggest you look in the mirror at some point.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
- Prev by Date:
Re: [tip:perf/core] bitops: Provide compile time HWEIGHT{8,16,32,64}
- Next by Date:
Re: [tip:perf/core] bitops: Provide compile time HWEIGHT{8,16,32,64}
- Previous by thread:
Re: [tip:perf/core] bitops: Provide compile time HWEIGHT{8,16,32,64}
- Next by thread:
Re: [tip:perf/core] bitops: Provide compile time HWEIGHT{8,16,32,64}
- Index(es):
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]